Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

check cluster id #1474

Closed
wants to merge 1 commit into from
Closed

check cluster id #1474

wants to merge 1 commit into from

Conversation

AricSu
Copy link

@AricSu AricSu commented Jul 27, 2022

Issue Number: close #1473

What problem does this PR solve?

avoid table data inconsistency with table index.

What is changed and how it works?

  1. get cluster id from tidb port using select substring(type,8) from METRICS_SCHEMA.PD_CLUSTER_METADATA limit 1;
  2. get cluster id from pd api using /pd/api/v1/cluster
  3. compare result of the two value,if it's equal,it will continue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AricSu
Copy link
Author

AricSu commented Jul 27, 2022

/close

@ti-chi-bot ti-chi-bot closed this Jul 27, 2022
@ti-chi-bot
Copy link
Member

@jansu-dev: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lightning imports data to non-destination cluster and leads to index inconsistency with data
3 participants
@AricSu @ti-chi-bot @CLAassistant